chore: move pnpm overrides from package.json to pnpm-workspace.yaml#27043
Draft
alexvy86 wants to merge 1 commit intomicrosoft:mainfrom
Draft
chore: move pnpm overrides from package.json to pnpm-workspace.yaml#27043alexvy86 wants to merge 1 commit intomicrosoft:mainfrom
alexvy86 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
pnpm v10 supports overrides natively in pnpm-workspace.yaml, which is their canonical location going forward. This moves all `pnpm.overrides` entries and their associated comment arrays from package.json to the corresponding pnpm-workspace.yaml across all 14 workspaces. YAML comments replace the JSON comment arrays (comments, commentsOverrides, overrideComments, overridesComments) so the documentation for each override is preserved inline next to the override it describes. Where onlyBuiltDependencies was already duplicated between package.json and pnpm-workspace.yaml, the package.json copy is removed since the yaml is the authoritative source. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alexvy86
changed the title
Contributor
Author
|
I'd like to move forward with this to get better support for comments for overrides, but right now Syncpack doesn't support looking at versions in Issues tracking this or related functionality: |
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pnpm v10 supports
overridesnatively inpnpm-workspace.yaml, which is their canonical location going forward. This moves allpnpm.overridesentries and their associated comment arrays frompackage.jsonto the correspondingpnpm-workspace.yamlacross all 14 workspaces.comments,commentsOverrides,overrideComments,overridesComments) so override documentation is preserved inline next to each overrideonlyBuiltDependencieswas already duplicated betweenpackage.jsonandpnpm-workspace.yaml, thepackage.jsoncopy is removed since the yaml is the authoritative sourcepnpm install --frozen-lockfile— all no-ops, no lockfile changes28 files changed across 14 workspaces (14
package.json+ 14pnpm-workspace.yaml), 298 override entries moved total.Reviewer Guidance
The review process is outlined on this wiki page.
This is a pure config migration — no code changes. The best way to verify is to confirm
pnpm install --frozen-lockfileis a no-op in each workspace after the change.